feat(axe.sansPolyfills): add axe version without polyfills #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WilcoFiers for v4, should we just make |
|
I'm in favor of delaying this until v4 and shipping without any polyfills by default. |
|
This saves a lot less space then I thought it would. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the file size of axe from 1.1 MB to 905 KB unminified, and 471 KB to 396 KB minified.
We had discussed moving to core-js for our polyfills, but decided against it in another pr due to the file size increase. However, since we have a version without polyfills, we can use that version in our extensions which do not need the polyfills. (FYI, core-js polyfills only add .05 MB to axe.js, going from 1.06 MB to 1.11 MB)
Also, I'm not sure why we were bothering to beautify the code before minifying it. Our code is already run through prettier so we don't need to beautify that, which means we were beautifying the babel output which seems unnecessary since we're never debugging that code. I also simplified the uglify code options.
Closes issue: #1935
Reviewer checks
Required fields, to be filled out by PR reviewer(s)